Bugs/reports

InceptionHosting

1. Quoting is broken - nginx/rewrite related issue - will take a deeper look in the morning. (99% fixed)
2. Emails have http instead of https and missing names. - will take a deeper look in the morning.
3. No thanks button - will take a deeper look in the morning. (Thanks button now in place - full page reload issue known)
4. I will probably move this site to another server tomorrow anyway for a bit of future proofing and better backups so I will see if issues 1 - 3 exist when it is moved, this one has a funky setup anyway as I used runcloud to deploy it.
5. Emoji's are being centered - i will pray for help.

AlwaysSkint

Disappointed that you didn't use a 1-click installer and have it fully operational in 10 minutes, like some people think. :-/

Get some sleep - you'll need it!

InceptionHosting

Honestly with vanilla it may be the safest option haha.

InceptionHosting

@AlwaysSkint said:
Get some sleep - you'll need it!

Fixed the quotes issue first though, that was annoying!

flips

Are these emojis supposed to be centered (they are on mobile here)

InceptionHosting

hmm

AlwaysSkint

@flips said:
Are these emojis supposed to be centered (they are on mobile here)

Gee the maun a chance! LET him sleep.

@AlwaysSkint said:
Disappointed that you didn't use a 1-click installer and have it fully operational in 10 minutes, like some people think. :-/

flips

@AlwaysSkint said:

@flips said:
Are these emojis supposed to be centered (they are on mobile here)

Gee the maun a chance! LET him sleep.

Sweet dreams

ITLabs

Everyone is getting a "Hosting Provider" role.
Edit: oh, sorry, i just saw that hzr had already reported this.

poisson

Just a tiny little thing about the insertion of a space between the "Thanked by #" and the nicks that follow. I am a little OCD because of my profession. Once again, you have my thanks @AnthonySmith for spending time on this!

kkrajk

A dislike / thumbs down button would be good...

Solaire

@AnthonySmith said:
Emoji's are being centered - i will pray for help.

In "themes/keystone/design/custom_default.css" remove "display: block;" from the ".UserContent p img" block. Should be found at line 6651 and onwards.

BlaZe

I don't see @Nekki made a moderator here. I think its a bug.

InceptionHosting

@BlaZe said:
I don't see @Nekki made a moderator here. I think its a bug.

I agree, but he is not actually here (yet?) and has a big role to fulfill on LET atm with BF/CM coming up.

InceptionHosting

please dont center

InceptionHosting

Emoji's disabled for now while I figure out why they center

poisson

@AnthonySmith said:
please dont center

AlwaysSkint

^ Putin wannabes

Solaire

@AnthonySmith said:
Emoji's disabled for now while I figure out why they center

https://talk.lowendspirit.com/discussion/comment/81/#Comment_81

InceptionHosting

@Solaire said:

@AnthonySmith said:
Emoji's disabled for now while I figure out why they center

https://talk.lowendspirit.com/discussion/comment/81/#Comment_81

Sorry, I am old and blind

InceptionHosting

@Solaire said:

@AnthonySmith said:
Emoji's disabled for now while I figure out why they center

https://talk.lowendspirit.com/discussion/comment/81/#Comment_81

Done but erm: :'(

Solaire

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:
Emoji's disabled for now while I figure out why they center

https://talk.lowendspirit.com/discussion/comment/81/#Comment_81

Done but erm: :'(

It's still there. Maybe the cache needs clearing?

InceptionHosting

oh its working now

Solaire

@AnthonySmith
Here goes the fix to the Thanks plugin. In "class.thankfulpeople.plugin.php", replace:

$Sender->AddJsFile('jquery.expander.js');
$Sender->AddCssFile('plugins/ThankfulPeople2/design/thankfulpeople.css');
$Sender->AddJsFile('plugins/ThankfulPeople2/js/thankfulpeople.functions.js');

with

$Sender->addJsFile('jquery.expander.js', 'plugins/ThankfulPeople');
$Sender->addCssFile('thankfulpeople.css', 'plugins/ThankfulPeople');
$Sender->addJsFile('thankfulpeople.functions.js', 'plugins/ThankfulPeople');

Additionally, as already pointed out, in "thankfulpeople.functions.js", replace

$('span.Thank > a, span.UnThank > a').live('click', function(){

with

$('span.Thank > a, span.UnThank > a').on('click', function(){

InceptionHosting

next thing to get on top of is why vanilla loads the emoji's over http rather that https causing mixed content issues
edit: ah its my backend config, will force HSTS when I get a minute to do that properly

Solaire

@AnthonySmith said:
oh its working now

Yeah, looks like us users need to force our browser to empty the cache. Should automagically resolve over the next few hours for users who don't force it.

InceptionHosting

@Solaire

Solaire

@AnthonySmith said:
@Solaire

Yeah that looks about right

InceptionHosting

@Solaire still jumping to the top on click (I updated the js to .on)

Solaire

@AnthonySmith said:
@Solaire still jumping to the top on click (I updated the js to .on)

It's still not loading the Javascript file, though that was the only fix needed in my Vanilla 3.3 test set-up. Do you have any PHP cache enabled?

InceptionHosting

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Solaire

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

Solaire

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

From: https://open.vanillaforums.com/addon/thankfulpeople2-plugin

Solaire

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

Figured. Please adjust the "class.thankfulpeople.plugin.php" accordingly (note the 2 at the end):

        $Sender->addJsFile('jquery.expander.js', 'plugins/ThankfulPeople2');
        $Sender->addCssFile('thankfulpeople.css', 'plugins/ThankfulPeople2');
        $Sender->addJsFile('thankfulpeople.functions.js', 'plugins/ThankfulPeople2');

Also, sorry for the crappy "Thanks" link right now. If you have an older version, please restore from there and apply the code above. Else, comment line 161 and 169 and uncomment lines 160 and 168

InceptionHosting

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:

@AnthonySmith said:

@Solaire said:
Do you have any PHP cache enabled?

Nope, I have an Nginx+Apache hybrid setup so I can use the required htaccess files for vanilla to actually work though, but i doubt that would be the issue.

Here's the complete, modified, class.thankfulpeople.plugin.php https://pastebin.com/RJf9Dmub.
If you want to make sure the function is actually being hit, put an echo followed by a die (i.e. echo "HITT"; die;).

Replaced, sorry but could you explain that last part to me like I am 5 or 70 years old? where specifically do I put that?

You'd put that in front of the code block you adapted. That said, since I changed the "Thanks" thingy I reckon it's not a PHP cache issue. Is your plugin in "plugins/ThankfulPeople"?

Its /plugins/ThankfulPeople2/

Figured. Please adjust the "class.thankfulpeople.plugin.php" accordingly (note the 2 at the end):

      $Sender->addJsFile('jquery.expander.js', 'plugins/ThankfulPeople2');
      $Sender->addCssFile('thankfulpeople.css', 'plugins/ThankfulPeople2');
      $Sender->addJsFile('thankfulpeople.functions.js', 'plugins/ThankfulPeople2');

Also, sorry for the crappy "Thanks" link right now. If you have an older version, please restore from there and apply the code above. Else, comment line 161 and 169 and uncomment lines 160 and 168

Back in business, I guess unthank is not so imprtant right now. happy days, appreciate the assistance!

InceptionHosting

@Ympker you can thank without reload now thanks to @Solaire

poisson

Emoji fixed after a Shift+refresh. Thanks working properly and doesn't jump up anymore, either on my computer or mobile. Thanks @Solaire for the help!

InceptionHosting

The temptation to change "Thanked by :" to "Amitz? :" is overwhelming

Solaire

@AnthonySmith said:
Back in business, I guess unthank is not so imprtant right now. happy days, appreciate the assistance!

You're most welcome . Unthank is a setting apparently (according to the README):

$Configuration['Plugins']['ThankfulPeople']['AllowTakeBack'] = true;

Should go in conf/config.php I guess.

InceptionHosting

so it is..

Ympker

I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

Ympker

@AnthonySmith said:
@Ympker you can thank without reload now thanks to @Solaire

Awesome!

InceptionHosting

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

Solaire

@AnthonySmith said:

@Ympker said:
I can't really post an image based on an url using mobile. There seems to not exist an "upload/submit" button.

I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

Chrome can emulate any sort of device . I can have a look later.

poisson

@AnthonySmith said:
I still use a samsung galaxy S2... I wont be troubleshooting that one any time soon haha.
Maybe the ipad in moble view will work to take a look.

No kidding..

vimalware

There seems to be lots of unnecessary vertical space, when text wraps around in the comment editor.(mobile Firefox on Android)
This could do with tweaking, to be able to distinguish between user-inserted newlines vs wraparounds.

InceptionHosting

@vimalware said:
There seems to be lots of unnecessary vertical space, when text wraps around in the comment editor.(mobile Firefox on Android)
This could do with tweaking, to be able to distinguish between user-inserted newlines vs wraparounds.

Yes I noticed that too, the plan is to see if the community is viable, has any life blood beyond the first 30 days, take stock of things, start monetizing in 2020, use proceeds to pay for development work to be done, something that LET never did despite the obvious requirements.

So small annoyances like this wont be made worse by me just tinkering.

InceptionHosting

Turns out user driven theme switching is not so simple, I will pop "user CSS selector options" on the long term dev/features list.

poisson

I think the mobile experience is quite acceptable and we can get a pro to look at it a little later. I am confident this will live beyond 30 days!